Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: try using references instead of constantly indexing filter parameters #898

Open
azonenberg opened this issue Sep 24, 2024 · 1 comment
Labels
cleanup Removing cruft core
Milestone

Comments

@azonenberg
Copy link
Collaborator

Avoids the needs for member variables that just store string names.

Instead, have a reference initialized in the constructor.

@azonenberg azonenberg added cleanup Removing cruft core labels Sep 24, 2024
@azonenberg azonenberg added this to the v0.2 milestone Oct 29, 2024
@azonenberg
Copy link
Collaborator Author

In progress for triggers now, also doing this for new filters. We should make a checklist of what's been converted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Removing cruft core
Projects
None yet
Development

No branches or pull requests

1 participant