Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malloc.c:22:87: error: use of undeclared identifier 'MAP_ANONYMOUS' #665

Open
ryandesign opened this issue Jun 18, 2024 · 5 comments
Open
Labels

Comments

@ryandesign
Copy link

ngs fails to build on OS X 10.10 and earlier.

malloc.c:22:87: error: use of undeclared identifier 'MAP_ANONYMOUS'

Here's a recent build log: https://build.macports.org/builders/ports-10.10_x86_64-builder/builds/274533/steps/install-port/logs/stdio

On older macOS and BSD, MAP_ANONYMOUS was called MAP_ANON. You could use:

#ifndef MAP_ANONYMOUS
#define MAP_ANONYMOUS MAP_ANON
#endif

I previously reported this to MacPorts: https://trac.macports.org/ticket/64195

@ilyash-b ilyash-b added the bug label Jun 18, 2024
@ilyash-b
Copy link
Contributor

Do we have statistics about installations? Is anyone actually using this port on such an old system? The latest update to that version was in 2017. I don't know whether it would be a good decision to support that version.

@ryandesign
Copy link
Author

MacPorts supports Mac OS X 10.4 and later. There are a handful of MacPorts users very passionate about supporting older systems. If you do not wish to include this simple change in your software we can fix it on the MacPorts side by using our legacy support library but I like to give upstream developers the chance to fix their software at the source so that it can benefit the largest audience.

@ryandesign
Copy link
Author

Do we have statistics about installations?

MacPorts opt-in installation statistics are here: https://ports.macports.org/statistics/

@ilyash-b
Copy link
Contributor

I'll need some time to get to this. Need a clean environment to experiment with. Figuring out what would be practical for me.

@ilyash-b
Copy link
Contributor

How can I reproduce this? Both AWS AMIs and GitHub actions images don't have such old versions. What would be a practical way for me to access an environment in which I can reproduce the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants