Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support uglify #68

Closed
StephanHoyer opened this issue Feb 15, 2018 · 2 comments
Closed

support uglify #68

StephanHoyer opened this issue Feb 15, 2018 · 2 comments

Comments

@StephanHoyer
Copy link

would be great to allow to get the filesize when uglified. I have no uglified version in my repo but want to show the size taking uglification into account.

Would be great, if you would support this.

@ngryman
Copy link
Owner

ngryman commented Feb 27, 2018

Hey,

I would like to keep Badge Size as simple as possible and be as agnostic as possible when it comes to the file content. Adding Uglify here would make Badge Size aware of JavaScript and start messing with its content. It's only made to advertise the size of a given file in your repo. The rest is left to the developer.

If you do want to advertise the uglified version of your file, you could have an uglified version of your file in your npm package and reference that URL (ie. dist/mylib.min.js) or you could eventually commit it to your repo. That's a very common practice that should allow you to do what you want.

@ngryman ngryman closed this as completed Feb 27, 2018
@paulmelnikow
Copy link

Just a heads up that Shields recently added a badge for Bundlephobia, which shows a library's minified or minzipped size. It hasn't been deployed yet but hopefully will be soon. badges/shields#1481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants