fix: type mismatch when upgrade to ts2.6

[sandangel]

Refs: #709

[coveralls]

Coverage remained the same at 93.533% when pulling 56d75a9 on sandangel:fix-ts2.6 into 839b42a on ngrx:master.

[brandonroberts]

This is to support strict: true correct? We're already building against 2.6 in the repo. We're not going to change Action to any as we lose the type safety.

[sandangel]

yes, this is for supporting strict: true.
could you suggest a better fix for map type between reducer and action type when there are multiple features in ActionReducerMap ?
currently this won't work:

import * as fromAuth from './auth.reducer';
import * as fromToken from './token.reducer';

export interface AuthFeatureState {
  authState: fromAuth.AuthState;
  tokenState: fromToken.TokenState;
}

export const reducers1: ActionReducerMap<AuthFeatureState> = {
  authState: fromAuth.authReducer, // <- error type string is not assignable to string literal
  tokenState: fromToken.tokenReducer // <- error
};

export const reducers2: ActionReducerMap<AuthFeatureState, AuthActions | TokenActions> = {
  authState: fromAuth.authReducer, // <- error type of TokenActions is not assignable to AuthActions
  tokenState: fromToken.tokenReducer // <- error
};

user have manually cast ActionReducerMap<AuthFeatureState, any> for ts to compile.

[sandangel]

if you not agree to change the default type variable in ActionReducerMap, I can revert it, but do you consider the fix for routerStore signature ?

[brandonroberts]

The routerStore signature fix is ok. I'd rather use ActionReducerMap<AuthFeatureState, any> for now but those changes don't impact this repo as strict: true isn't enabled for the example-app

[sandangel]

hi @brandonroberts , I have revert the ActionReducerMap default type, please check.