Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Entity): Avoid for..in iteration in sorted state adapter #805

Merged
merged 1 commit into from
Feb 11, 2018

Conversation

livthomas
Copy link
Contributor

I have just noticed that the changes in commit f871540 introduced to the sorted state adapter the same problem I have already fixed in the unsorted state adapter. So I'm adding the reproducer to those tests as well.

Just one question: Where can we expect these fixes to be released? Is there going to be version 5.0.2 anytime soon?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 92.76% when pulling 235bec3 on livthomas:sorted-adapter-for-in into 779d689 on ngrx:master.

@MikeRyanDev
Copy link
Member

There will probably be a 5.1.0 at some point. Not sure when, but if you need the fixes soon then I would recommend using the nightlies for now.

Thanks for these fixes!

@MikeRyanDev MikeRyanDev merged commit 4192645 into ngrx:master Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants