fix(StoreDevtools): Do not send full liftedState on simple actions. #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔥 Thank you for the PR! I'll get this reviewed and tested quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of users have reported significant slowdown when using store-devtools. Slowdowns were more noticeable with larger states and larger values of maxAge.
ngrx/store-devtoolszalmoxisus/redux-devtools-extension#314It appears that @ngrx/store-devtools currently sends the full lifted state to the extension, which requires serializing not just the current state but all previous states that have not been committed. With this change, only the current action and state snapshots are serialized during normal app actions. When app state is recomputed, a full liftedState update is sent.
Note: Also requires optionally propagating maxAge into ReduxDevtoolsExtension.connect.