Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration schematic for renaming rxMethod.unsubscribe to destroy. #4585

Open
1 of 2 tasks
markostanimirovic opened this issue Nov 12, 2024 · 3 comments
Open
1 of 2 tasks
Assignees
Labels
19.x Accepting PRs community watch Someone from the community is working this issue/PR Project: Signals

Comments

@markostanimirovic
Copy link
Member

markostanimirovic commented Nov 12, 2024

Which @ngrx/* package(s) are relevant/related to the feature request?

signals

Information

The migration schematic should rename rxMethod.unsubscribe to destroy.

Before:

const logNumber = rxMethod<number>(tap(console.log));
const numRef = logNumber(interval(1_000));

numRef.unsubscribe();
logNumber.unsubscribe();

After:

const logNumber = rxMethod<number>(tap(console.log));
const numRef = logNumber(interval(1_000));

numRef.destroy();
logNumber.destroy();

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@tanmaytare
Copy link
Contributor

I would be willing to submit a PR to fix this issue ,please assign me

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Nov 13, 2024
@timdeschryver
Copy link
Member

Thanks @tanmaytare

@timdeschryver
Copy link
Member

@tanmaytare We want to mention that it could be that this won't be possible with our current schematics setup.
It would be great of course if we're able to do this, but we wanted to give you a heads-up so you're aware of it and don't spend too much of your time into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19.x Accepting PRs community watch Someone from the community is working this issue/PR Project: Signals
Projects
None yet
Development

No branches or pull requests

3 participants