Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): set correct default value type #4307

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

geromegrignon
Copy link
Contributor

closes #4278

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The default entity value is "false" in place of false

Closes #4278

What is the new behavior?

The default value is false, as a boolean

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a897149
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/662961476abaab000880955f
😎 Deploy Preview https://deploy-preview-4307--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markostanimirovic markostanimirovic changed the title fix(schematics): default value type fix(schematics): set correct default value type Apr 24, 2024
@brandonroberts brandonroberts merged commit 51034e6 into ngrx:main Apr 25, 2024
5 checks passed
@brandonroberts
Copy link
Member

Thanks @geromegrignon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schematics 'feature' gives error "Property 'entity' does not match the schema. 'false' should be a 'boolean'."
3 participants