Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(signals): avoid unecessary observable conversions in rxMethod #4219

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Performance improvements

What is the current behavior?

rxMethod converts signals and static inputs into observables.

What is the new behavior?

rxMethod does not convert signals and static inputs into observables which reduces more than 1kB.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit e8ddecd
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/65b842809608440008387722

@brandonroberts brandonroberts merged commit fa45d92 into main Jan 31, 2024
5 checks passed
@brandonroberts brandonroberts deleted the perf/signals/rx-method branch January 31, 2024 03:27
rainerhahnekamp added a commit to rainerhahnekamp/ngrx that referenced this pull request Jan 31, 2024
rainerhahnekamp added a commit to rainerhahnekamp/ngrx that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants