Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): standalone support for ng add @ngrx/data #4019

Merged

Conversation

va-stefanek
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently ng add do not have standalone for @ngrx/data package

Closes #3935

Add standalone configuration support for ng add command for @ngrx/data package

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 62aecd2
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/65076dd038ad4900085b37e2

@va-stefanek va-stefanek force-pushed the feature/3935-standalone-ngrx-data branch from b88dc25 to 65b502c Compare September 13, 2023 17:37
@brandonroberts
Copy link
Member

Thanks @va-stefanek. The snapshot test should be committed also to fix the failing test

@va-stefanek va-stefanek force-pushed the feature/3935-standalone-ngrx-data branch from 65b502c to e8e75d2 Compare September 16, 2023 19:31
@va-stefanek
Copy link
Contributor Author

@brandonroberts done :)

@va-stefanek va-stefanek force-pushed the feature/3935-standalone-ngrx-data branch from e8e75d2 to e04648b Compare September 17, 2023 17:43
@va-stefanek va-stefanek force-pushed the feature/3935-standalone-ngrx-data branch from e04648b to ff2e759 Compare September 17, 2023 21:21
@va-stefanek va-stefanek force-pushed the feature/3935-standalone-ngrx-data branch from ff2e759 to 62aecd2 Compare September 17, 2023 21:21
@markostanimirovic markostanimirovic merged commit fdd701e into ngrx:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add standalone support to ng add for NgRx Data
3 participants