-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component-store): added custom equal option in select #3933
feat(component-store): added custom equal option in select #3933
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just a little nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rosostolato! The code and tests look good to me. A small suggestion for docs:
Added `equal` option to provide a custom equality function for `distinctUntilChanged` in `select` method. Closes #3931
Those were great feedback! Thank you, guys! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks @rosostolato!
Nice work! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
select
usesdistinctUntilChanged
but there was no way to provide a custom equality fn.Closes #3931
What is the new behavior?
Added
equal
option to provide a custom equality function fordistinctUntilChanged
inselect
method.Does this PR introduce a breaking change?
Other information