feat(component): make LetDirective and PushPipe standalone #3826
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
|
@timdeschryver , @markostanimirovic Could you maybe have a look? Btw, do you have any idea why the build is failing? |
|
@stefanoslig this issue was already to assigned to be worked on, ping them in the original issue to see if they still want to work on it first before proceeding here |
|
I closed this since @adyngom is going to work on this |
|
@brandonroberts could you maybe help me with the failed pipeline? |
…xamples for the deprecated code
…based on the feedback in the PR
.yarn/install-state.gz
Outdated
There was a problem hiding this comment.
I guess this file is pushed by mistake 👀
| @@ -154,6 +154,129 @@ import { createMockStore } from '@ngrx/store/testing'; | |||
| const mockStore = createMockStore(); | |||
| ``` | |||
|
|
|||
| #### LetModule | |||
There was a problem hiding this comment.
Deprecations need to be added as a separate section. Move added lines to the bottom of this file and add the following headings:
## Deprecations
### @ngrx/component
#### LetModule
....
#### PushModule
...There was a problem hiding this comment.
Oops, yeah, you're right!
markostanimirovic
changed the title
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
With this PR we make the LetDirective and PushPipe standalone. The LetModule and PushModule have been marked as deprecated and they can still be used.
Ideally, I would like to rename the directive from
LetDirective=>NgRxLetand the pipe fromPushPipe=>NgRxPushbut this would introduce a lot of changes. Maybe something for the future?Another thing we can consider for the future is a migration schematic.
What is the current behavior?
Closes #
#3804
What is the new behavior?
Does this PR introduce a breaking change?
Other information