Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(router-store): remove deprecated getSelectors method #3815

Conversation

apramendorfer
Copy link
Contributor

Removes deprecated getSelectors method from router-store

Closes #3813

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: removes deprecated method

What is the current behavior?

Closes #3813

What is the new behavior?

The deprecated method getSelectors is removed from router-store

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Migration script for the renaming of the method is already in place.

Removes deprecated getSelectors from router-store

Closes ngrx#3813
@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 355d913
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64248570bdc7410008f45e8c

@apramendorfer apramendorfer deleted the feature/RemoveDeprecatedRouterSelectors branch March 29, 2023 18:41
brandonroberts pushed a commit that referenced this pull request Apr 15, 2023
Closes #3815 

BREAKING CHANGES:

The deprecated `getSelectors` function has been removed from the `@ngrx/router-store` package.

BEFORE:

The @ngrx/router-store package exports the `getSelectors` function. 

AFTER:

The @ngrx/router-store package no longer exports the `getSelectors` function. A migration has been provided to replace existing usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the deprecated getSelectors method
1 participant