Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add provideStore and provideState functions for standalone APIs #3539

Merged
merged 7 commits into from
Aug 23, 2022
Merged

feat(store): add provideStore and provideState functions for standalone APIs #3539

merged 7 commits into from
Aug 23, 2022

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Aug 16, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3526

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit a7cb25c
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6303d59ccb68630008f76a88

@brandonroberts brandonroberts changed the title WIP feat(store): add provideStore and provideState functions for standalone APIs feat(store): add provideStore and provideState functions for standalone APIs Aug 16, 2022
markostanimirovic
markostanimirovic reviewed Aug 18, 2022
View reviewed changes
modules/store/src/provide_store.ts Outdated Show resolved Hide resolved
modules/store/src/provide_store.ts Outdated Show resolved Hide resolved
modules/store/src/provide_store.ts Outdated Show resolved Hide resolved
markostanimirovic
markostanimirovic approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Brandon! 🏆

timdeschryver
timdeschryver approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@timdeschryver timdeschryver merged commit 5639c1e into master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

@markostanimirovic markostanimirovic markostanimirovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store: Introduce Standalone API for NgRx Store
3 participants
@brandonroberts @markostanimirovic @timdeschryver