fix(component-store): accept error type in tapResponse with strict generic checks #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for ab8e938 at https://previews.ngrx.io/pr3068-ab8e9387/ |
markostanimirovic
force-pushed
the
fix/component-store/tap-response-error-type
branch
from
97f065b to
ab8e938
Compare
timdeschryver
approved these changes
Jul 10, 2021
| import { tapResponse } from '@ngrx/component-store'; | ||
| import { concatMap, finalize } from 'rxjs/operators'; | ||
|
|
||
| describe('tapResponse', () => { |
There was a problem hiding this comment.
Thanks for writing these 👍
brandonroberts
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
tapResponsecannot accept error type whennoStrictGenericChecksisfalse.This bug is reported here.
What is the new behavior?
tapResponseaccepts error type whennoStrictGenericChecksisfalse.Does this PR introduce a breaking change?
Other information
Added unit and type tests for
tapResponseoperator.