feat(router-store): Add urlAfterRedirects to Minimal #2775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Even if the developer is using
RouterState.Minimal
we should be providing theurlAfterRedirects
property, that exists onNavigationEnd
Router even.Is got broken when the default implementation was switched from
Full
toMinimal
, however ourMinimal
should still cover this case.Also, fix the router tests - with just
async () =>
they were not testing the assertions withinsubscribe(...)
😳Discovered that, because I first try to fail the test, before making sure that new code passes.
Does this PR introduce a breaking change?
Other information