Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-store): adjust updater to accept partials #2765

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Adjust updater typings.
New type would work properly with Partial<Obj> interfaces, as well as with simple unknown if that's what the developer wants to pass to the updater.
It would still return () => void if the second argument is not specified.

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #2754

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@alex-okrushko alex-okrushko added the WIP Not ready for review label Oct 27, 2020
@alex-okrushko alex-okrushko removed the request for review from timdeschryver October 27, 2020 19:44
@alex-okrushko
Copy link
Member Author

Ran into the issue with enums when syncing it into google3. (added WIP for now)

@alex-okrushko alex-okrushko removed the WIP Not ready for review label Oct 27, 2020
@alex-okrushko
Copy link
Member Author

Also ran into this case cartant/ts-snippet#37

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 27, 2020

Preview docs changes for 22de7f7 at https://previews.ngrx.io/pr2765-22de7f7f/

@timdeschryver timdeschryver merged commit b54b9b6 into master Oct 31, 2020
@timdeschryver timdeschryver deleted the cs-updater-types branch October 31, 2020 18:46
@alex-okrushko alex-okrushko restored the cs-updater-types branch November 4, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/component-store Updater does not accept a Partial object
4 participants