Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): ng-add removes other workspace cli options #2731

Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix(schematics): ng-add removes other workspace cli options #2731

merged 1 commit into from
Oct 7, 2020

Conversation

eneajaho
Copy link
Contributor

@eneajaho eneajaho commented Oct 5, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When ng-add is exectuted it removes other workspace cli options and includes only { defaultCollection: '@ngrx/schematics' } on it.

What is the new behavior?

This fix adds { defaultCollection: '@ngrx/schematics' } to options and doesn't remove the current ones (other options may be ex: analytics).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

When ng-add was exectuted it reseted workspace cli value and only included { defaultCollection: '@ngrx/schematics' } and removed the other options on it. 
This fix adds { defaultCollection: '@ngrx/schematics' } to options and doesn't remove the current options (other options may be: analytics).
@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 5, 2020

Preview docs changes for b98ea95 at https://previews.ngrx.io/pr2731-b98ea953/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit 37354aa into ngrx:master Oct 7, 2020
@timdeschryver timdeschryver added the hacktoberfest-accepted PR qualifies for Hacktoberfest label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR qualifies for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants