refactor(component-store): fine-tune effect types #2645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
remove
EffectReturnFn
and make the effect type stricter and more predictable.For example, previously if effect was
const e = effect((o: Observable<string>) => ....)
it was still possible to calle()
without passing anystring
s.What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Some tests needed to be adjusted because we are stricter with types and actually enforce the argument requirement (or enforce not passing one).
Other information