Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component-store): fine-tune effect types #2645

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
remove EffectReturnFn and make the effect type stricter and more predictable.
For example, previously if effect was const e = effect((o: Observable<string>) => ....) it was still possible to call e() without passing any strings.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Some tests needed to be adjusted because we are stricter with types and actually enforce the argument requirement (or enforce not passing one).

Other information

@alex-okrushko alex-okrushko force-pushed the cs-effect-type-tuning branch from 66b3237 to fc5af33 Compare August 5, 2020 02:45
@ngrxbot
Copy link
Collaborator

ngrxbot commented Aug 5, 2020

Preview docs changes for fc5af33 at https://previews.ngrx.io/pr2645-fc5af33b/

@brandonroberts brandonroberts merged commit ee92912 into master Aug 5, 2020
@brandonroberts brandonroberts deleted the cs-effect-type-tuning branch August 5, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants