fix(data): make mergeServerUpserts change state immutably (#2374) #2389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Runtime error thrown if performing a QUERY action (with the default preserve changes strategy) after an UPSERT action due to mutably changing state.
Closes #2374
What is the new behavior?
mergeServerUpserts
which is used by QUERY actions changes state immutably without error.Does this PR introduce a breaking change?
Other information
I believe this also fixes #2307
A failing test that simulates runtime checks is the following (not included as this becomes immediately redundant):