Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): Angular 9 style ModuleWithProvider (#2356) #2357

Merged
merged 1 commit into from
Feb 7, 2020
Merged

fix(data): Angular 9 style ModuleWithProvider (#2356) #2357

merged 1 commit into from
Feb 7, 2020

Conversation

debuggerpk
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

NgRx Data does not compile with Angular 9. Gives error EntityDataModule.forRoot returns a ModuleWithProviders type without a generic type argument.

Closes #2356

What is the new behavior?

NgRx Data now compiles flawlessly with Angular 9.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 7, 2020

Preview docs changes for e85da6b at https://previews.ngrx.io/pr2357-e85da6b/

@brandonroberts brandonroberts merged commit 182f140 into ngrx:master Feb 7, 2020
@brandonroberts
Copy link
Member

Thanks @debuggerpk!

@debuggerpk
Copy link
Contributor Author

@brandonroberts this is kinda a road blocker for angular 9 upgrade. Can we release it out in the wild?

@brandonroberts
Copy link
Member

We'll cut another beta next week. If you need it earlier, use the nightly builds

https://ngrx.io/guide/nightlies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntityDataModule.forRoot returns a ModuleWithProviders type without a generic type argument.
4 participants