RFC: Capture the type of a selector's projector function in the MemoizedSelector type

[MikeRyanDev]

When testing a memoized selector's projector function we default the type of the projector to be any. This makes it difficult to catch type changes of the projector function in unit tests.

I recommend the type of MemoizedSelector be extended to have a third type parameter that captures the type of the projector function:

export interface MemoizedSelector<State, Result, ProjectorFn>
  extends Selector<State, Result> {
  release(): void;
  projector: ProjectorFn;
  setResult: (result?: Result) => void;
}

Describe any alternatives/workarounds you're currently using

Live with the lack of type safety. 😄

Other information:

If accepted, I would be willing to submit a PR for this feature

[X] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

[alex-okrushko]

Having the projector to be any bothered me as well. Would this be a better solution?

export interface MemoizedSelector<State, Result>
  extends Selector<State, Result> {
  release(): void;
  projector: (...args: any[]) => Result;
  setResult: (result?: Result) => void;
}

I'd rather not add third parameter to the MemoizedSelector (that doesn't have a default value) - it would break the world for me.

[brandonroberts]

I would propose adding a default value of AnyFn for ProjectorFn for version 8, and revisit the breaking change for version 9.

[MikeRyanDev]

@brandonroberts, @alex-okrushko To follow on, I would say that the interface provides a default value for the new third generic parameter:

export interface MemoizedSelector<State, Result, ProjectorFn = AnyFn>
  extends Selector<State, Result> {
  release(): void;
  projector: ProjectorFn;
  setResult: (result?: Result) => void;
}

but using inference from createSelector you get a more specific type for the third parameter.

[alex-okrushko]

This looks like a non-breaking change (unless some code erroneously was relying on a different return type).
We could change to the following:

export type DefaultProjectorFn<T> = (...args: any[]) => T;

export interface MemoizedSelector<State, Result, ProjectorFn = DefaultProjectorFn<Result>>
  extends Selector<State, Result> {
  release(): void;
  projector: ProjectorFn;
  setResult: (result?: Result) => void;
}

WDYT?

[brandonroberts]

👍

[jasonhodges]

I will take this one 👍