Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubscribe to the Effects stream after unhandled error #1851

Closed
alex-okrushko opened this issue May 11, 2019 · 1 comment
Closed

Resubscribe to the Effects stream after unhandled error #1851

alex-okrushko opened this issue May 11, 2019 · 1 comment
Assignees

Comments

@alex-okrushko
Copy link
Member

Based of #1224 (comment)

We would have the mapToAction operator to make it harder to miss errors, however it would be beneficial to still re-subscribe to the Effect if the unhandled error did go throw.

New behavior is helpful in 90% of the use cases, however, there are some where it might be surprising, for example if the stream has startWith operator it would be called again. For such corner cases we should provide the lever to turn it off, for example with additional {resubscribeOnError: false}, which would be part of the same config object as {dispatch: boolean}.

If accepted, I would be willing to submit a PR for this feature

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@timdeschryver
Copy link
Member

Resolved by #1881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants