Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @angular/http dep #1821

Closed
timdeschryver opened this issue May 5, 2019 · 5 comments
Closed

Remove @angular/http dep #1821

timdeschryver opened this issue May 5, 2019 · 5 comments

Comments

@timdeschryver
Copy link
Member

The @angular/http package has been deprecated.
From what I can see we're not depending on it, thus this can be removed?

@santoshyadavdev
Copy link
Contributor

@timdeschryver let me try this one.

@santoshyadavdev
Copy link
Contributor

Hi @timdeschryver ,
We need to wait I think till Angular 8 or update to angular 8.0 rc as platform-server still depends on @angular/http.

https://github.com/angular/angular/blob/8.0.0-beta.10/packages/platform-server/package.json#L20

@timdeschryver
Copy link
Member Author

@santoshyadavdev
Copy link
Contributor

santoshyadavdev commented May 5, 2019

Ok, I was not sure if we need to update other packages, but in that case, we need to update everything to rc.

@brandonroberts
Copy link
Member

Fixed via #1795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants