Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): Expand createReducer type signature to support up to ten action creators #1803

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

MikeRyanDev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Current type signature only supports type inference for up to three action creators

What is the new behavior?

This expands the type signature to support up to ten action creators. Highest I have internally is 7 so 10 felt like a good ceiling for now.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 25, 2019

Preview docs changes for 63359c5 at https://previews.ngrx.io/pr1803-63359c5/

@MikeRyanDev MikeRyanDev force-pushed the feat/expand-create-reducer-types branch from 63359c5 to 87cd089 Compare April 25, 2019 01:21
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 25, 2019

Preview docs changes for 87cd089 at https://previews.ngrx.io/pr1803-87cd089/

@brandonroberts brandonroberts merged commit 63e4926 into master Apr 25, 2019
@brandonroberts brandonroberts deleted the feat/expand-create-reducer-types branch April 25, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants