Schematics: Missing type for Union

[mikezks]

Minimal reproduction of the bug/regression with instructions:

Using ng g @ngrx/schematics:feature +state/app --group -c to generate a feature state with new createAction() results in following code:

export Union = typeof all;

Expected behavior:

Should be:

export type Union = typeof all;

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

"@ngrx/schematics": "8.0.0-beta.0"

Other information:

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

[timdeschryver]

Before picking this up, do we want to use union to export the actions or are we simply going to export the action creators?

[mikezks]

Good point, the new createReducer() does not need to have the action union type definition.

Maybe it would avoid possible errors to use the union type in the reducer function as well.

See #1746 discussion about the state type.

[brandonroberts]

This adds reducer schematics with createReducer and doesn't include any unions as we don't explicitly need them. #1785

[timdeschryver]

This is resolved via #1785.