refactor(RouterStore): change default state key to router #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
requested changes
Aug 22, 2018
BREAKING CHANGE: The default state key is changed from routerReducer to router
timdeschryver
force-pushed
the
pr/router-state-key
branch
2 times, most recently
from
e214dfe to
c1f0815
Compare
brandonroberts
requested changes
Aug 22, 2018
docs/router-store/api.md
Outdated
| @@ -1,5 +1,18 @@ | |||
| # API | |||
|
|
|||
| ## StoreRouterConnectingModule.forRoot | |||
There was a problem hiding this comment.
Change to Configuration Options
docs/router-store/api.md
Outdated
| @@ -1,5 +1,18 @@ | |||
| # API | |||
|
|
|||
| ## StoreRouterConnectingModule.forRoot | |||
|
|
|||
| To connect the Angular router module with the NgRx store module, import the store module via | |||
There was a problem hiding this comment.
Remove the function that accepts an object. Its going to be removed from the API
timdeschryver
force-pushed
the
pr/router-state-key
branch
from
c1f0815 to
55c6912
Compare
|
|
||
| To connect the Angular router module with the NgRx store module, import the store module via | ||
| `StoreRouterConnectingModule.forRoot()`. | ||
|
|
There was a problem hiding this comment.
What happened to the description for stateKey?
There was a problem hiding this comment.
I'm confused 😅
Like this you mean?
There was a problem hiding this comment.
😴 I must have been looking at a partial change. 👍
There was a problem hiding this comment.
No, I've recommitted. I must have done something wrong...
timdeschryver
force-pushed
the
pr/router-state-key
branch
from
55c6912 to
3b12eb6
Compare
brandonroberts
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1241
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Closes #1241
BREAKING CHANGE:
The default state key is changed from routerReducer to router