fix(effects): add support for Proxy objects in Effects (#2976)

Closes #2975
ngrx · Mar 23, 2021 · 5f5b679 · 5f5b679
1 parent 1cc1912
commit 5f5b679
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/modules/effects/spec/effect_creator.spec.ts b/modules/effects/spec/effect_creator.spec.ts
@@ -85,6 +85,14 @@ describe('createEffect()', () => {
       const fakeCreateEffect: any = () => {};
       class Fixture {
         a = fakeCreateEffect(() => of({ type: 'A' }));
+        b = new Proxy(
+          {},
+          {
+            get(_, prop) {
+              return () => Promise.resolve('bob');
+            },
+          }
+        );
       }
 
       const mock = new Fixture();

diff --git a/modules/effects/src/effect_creator.ts b/modules/effects/src/effect_creator.ts
@@ -77,11 +77,19 @@ export function getCreateEffectMetadata<
   const propertyNames = Object.getOwnPropertyNames(instance) as Array<keyof T>;
 
   const metadata: EffectMetadata<T>[] = propertyNames
-    .filter(
-      (propertyName) =>
+    .filter((propertyName) => {
+      if (
         instance[propertyName] &&
         instance[propertyName].hasOwnProperty(CREATE_EFFECT_METADATA_KEY)
-    )
+      ) {
+        // If the property type has overridden `hasOwnProperty` we need to ensure
+        // that the metadata is valid (containing a `dispatch`property)
+        // https://github.com/ngrx/platform/issues/2975
+        const property = instance[propertyName] as any;
+        return property[CREATE_EFFECT_METADATA_KEY].hasOwnProperty('dispatch');
+      }
+      return false;
+    })
     .map((propertyName) => {
       const metaData = (instance[propertyName] as any)[
         CREATE_EFFECT_METADATA_KEY