fix(store): add the missing bracket in immutability meta-reducer (#1721)

ngrx · Apr 10, 2019 · 56f8a59 · 56f8a59
1 parent 20a4d5e
commit 56f8a59
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/modules/store/spec/meta-reducers/immutability_reducer.spec.ts b/modules/store/spec/meta-reducers/immutability_reducer.spec.ts
@@ -23,7 +23,7 @@ describe('immutabilityCheckMetaReducer:', () => {
       immutabilityCheckMetaReducer((state, action) => {
         reduce(action);
         return state;
-      })({}, { type: 'invoke', numbers: [1, 2, 3] });
+      })({}, { type: 'invoke', numbers: [1, 2, 3], fun: function() {} });
     }
   });
 
@@ -48,7 +48,7 @@ describe('immutabilityCheckMetaReducer:', () => {
     });
 
     function invokeReducer(reduce: Function) {
-      immutabilityCheckMetaReducer((state, _action) => reduce(state))(
+      immutabilityCheckMetaReducer(state => reduce(state))(
         { numbers: [1, 2, 3] },
         { type: 'invoke' }
       );

diff --git a/modules/store/src/meta-reducers/immutability_reducer.ts b/modules/store/src/meta-reducers/immutability_reducer.ts
@@ -18,11 +18,12 @@ function freeze(target: any) {
   Object.getOwnPropertyNames(target).forEach(prop => {
     const propValue = target[prop];
     if (
-      hasOwnProperty(target, prop) && targetIsFunction
+      hasOwnProperty(target, prop) &&
+      (targetIsFunction
         ? prop !== 'caller' && prop !== 'callee' && prop !== 'arguments'
-        : true &&
-          (isObjectLike(propValue) || isFunction(propValue)) &&
-          !Object.isFrozen(propValue)
+        : true) &&
+      (isObjectLike(propValue) || isFunction(propValue)) &&
+      !Object.isFrozen(propValue)
     ) {
       freeze(propValue);
     }