Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lib to src for consistency #4

Open
robwormald opened this issue Jun 22, 2016 · 3 comments
Open

move lib to src for consistency #4

robwormald opened this issue Jun 22, 2016 · 3 comments

Comments

@robwormald
Copy link

No description provided.

@MikeRyanDev
Copy link
Member

Are you wanting it to be consistent across all ngrx projects? If that's the case, we'll need to update router, router-store, effects, notify, store-devtools, and store-log-monitor as well.

@robwormald
Copy link
Author

Yeah, I'd like to be consistent across projects and implement this proposal:

https://github.com/dherman/defense-of-dot-js/blob/master/proposal.md

TS source in /src
Output commonJS ES5 to the root
Output standard (ES) modules to /lib
Add module and modules.root to point to ESM entry point and modules

We'll implement the same in @angular and build our es module pipeline around it.

Thoughts?

@MikeRyanDev
Copy link
Member

Sounds good. To be clear, the ES modules we output to /lib need to be ES5 with ES6 modules, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants