Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ResolvedRefs/False/InvalidRouteKinds on Listeners with Invalid Route Kinds #774

Closed
kate-osborn opened this issue Jun 21, 2023 · 0 comments · Fixed by #799
Closed

Set ResolvedRefs/False/InvalidRouteKinds on Listeners with Invalid Route Kinds #774

kate-osborn opened this issue Jun 21, 2023 · 0 comments · Fixed by #799
Assignees
@ciarams87
Labels
area/gateway/core Relates to all Core features of Gateway enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Milestone
v0.5.0

Comments

@kate-osborn
Copy link
Contributor

The GatewayInvalidRouteKind conformance test expects the ResolvedRef/False/InvalidRouteKinds condition to be set on a Listener that specifies an invalid route kind.

Acceptance Criteria:

  • If a listener has an invalid route kind in the allowedRoutes.kinds list, set the ResolvedRefs/False/InvalidRouteKinds condition on the listener.
  • Make sure the GatewayInvalidRouteKind conformance test passes
@ja20222 ja20222 added this to the v0.5.0 milestone Jun 22, 2023
@ja20222 ja20222 added bug Something isn't working enhancement New feature or request area/gateway/core Relates to all Core features of Gateway and removed bug Something isn't working labels Jun 22, 2023
@mpstefan mpstefan mentioned this issue Jun 27, 2023
Closed
@ciarams87 ciarams87 mentioned this issue Jun 28, 2023
Merged
6 tasks
@ciarams87 ciarams87 self-assigned this Jun 28, 2023
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciarams87 ciarams87

Labels
area/gateway/core Relates to all Core features of Gateway enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Add NewListenerInvalidRouteKinds condition ciarams87/nginx-gateway-fabric
4 participants
@mpstefan @ciarams87 @kate-osborn @ja20222