Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release version in docs #2787

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

salonichf5
Copy link
Contributor

Update release version to 1.5.0 on main

@salonichf5 salonichf5 requested review from a team as code owners November 20, 2024 22:08
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks tests Pull requests that update tests helm-chart Relates to helm chart labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (9fb7b33) to head (767d42e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2787   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         107      107           
  Lines       10997    10997           
  Branches       50       50           
=======================================
  Hits         9883     9883           
  Misses       1054     1054           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

README.md Show resolved Hide resolved
site/content/get-started.md Show resolved Hide resolved
@salonichf5
Copy link
Contributor Author

salonichf5 commented Nov 20, 2024

@sjberman The rules seem pretty consistent of using surrounding blanks around code blocks. But I wonder too why it didn't error out when the PR was opened.

@salonichf5 salonichf5 force-pushed the chore/update-release-version branch from 8363d4b to 64c6d20 Compare November 20, 2024 23:40
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after saylor's requests go through 🚀 !

@salonichf5 salonichf5 enabled auto-merge (squash) November 21, 2024 17:09
@salonichf5 salonichf5 merged commit 702ec11 into nginx:main Nov 21, 2024
49 checks passed
salonichf5 added a commit to salonichf5/nginx-gateway-fabric that referenced this pull request Dec 5, 2024
Update release version to 1.5.0
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Update release version to 1.5.0
@bjee19 bjee19 mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants