Resolve FIXMEs for gateway-ctlr-name CLI arg #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
changed the title
kate-osborn
force-pushed
the
fix/hardcoded-namespace
branch
from
b1115d0 to
3078c2c
Compare
github-actions
bot
added
bug
f5yacobucci
reviewed
Sep 19, 2022
Removes requirement for namespace in gateway-ctlr-name CLI arg. Expected format is now DOMAIN/PATH. Valid examples include: "k8s-gateway.nginx.org/nginx-gateway-controller", "k8s-gateway.nginx.org/nginx-gateway/nginx-gateway-controller", and "k8s-gateway.nginx.org/nginx-gateway/nginx-gateway-controller/v2". Updated validation of argument to use the regex provided by the kubebuilder annotation for GatewayClass.Spec.controllerName. Updated manifests to use the controller name "k8s-gateway.nginx.org/nginx-gateway-controller".
Use re.MatchString instead of re.Match Co-authored-by: Michael Pleshakov <[email protected]>
kate-osborn
force-pushed
the
fix/hardcoded-namespace
branch
from
fbcb3ac to
29e6ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the FIXMEs involving the
gateway-ctlr-nameCLI argument.Removes the requirement for a namespace in
gateway-ctlr-nameCLI arg. The expected format is now DOMAIN/PATH. Valid examples include: "k8s-gateway.nginx.org/nginx-gateway-controller", "k8s-gateway.nginx.org/nginx-gateway/nginx-gateway-controller", and "k8s-gateway.nginx.org/nginx-gateway/nginx-gateway-controller/v2".Updates validation of argument to use the regex provided by the kubebuilder annotation for
GatewayClass.Spec.controllerName.Updates manifests to use the controller name "k8s-gateway.nginx.org/nginx-gateway-controller".
Removes unused GatewayConfig CRD