Correct header name validation #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a snip of what the HTTPRoute shows when it is applied with an invalid header name.
|
pleshakov
reviewed
Nov 9, 2023
bjee19
force-pushed
the
bug/incorrect-header-name-validation
branch
from
4820db0 to
ecf9e42
Compare
sjberman
approved these changes
Nov 10, 2023
kate-osborn
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Correct header name validation.
Problem: Header name validation was not being implemented by NGF thus any problems would be caught by nginx and would not be as visible.
Solution: NGF now validates header names and will show an error in the HTTPRoute status.
Testing: Added unit tests and manually tested that if trying to apply an HTTPRoute with an invalid header name, the HTTPRoute status is correctly showing the error.
Closes #766
Checklist
Before creating a PR, run through this checklist and mark each as complete.