Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Total and failed NGINX reloads #887

Closed
mpstefan opened this issue Jul 19, 2023 · 2 comments · Fixed by #1049
Closed

Metrics: Total and failed NGINX reloads #887

mpstefan opened this issue Jul 19, 2023 · 2 comments · Fixed by #1049
Assignees
Labels
metrics Additions or changes to metrics from NKG refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Milestone

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Jul 19, 2023

As an operator of an environment running NKG
I want to track the total number of NGINX reloads and failures for NGINX processes across my environment
So that I can correlate availability issues with excessive NGINX reloads or failures
And so that I can let the NKG know when reloads become a problem.

Acceptance

  • Total NGINX reloads and failed reloads are counted and reported via a Prometheus endpoint as a counter.
@mpstefan mpstefan modified the milestone: v1.1.0 Jul 19, 2023
@mpstefan mpstefan added the metrics Additions or changes to metrics from NKG label Jul 19, 2023
@mpstefan mpstefan added this to the v1.0.0 milestone Jul 20, 2023
@mpstefan
Copy link
Collaborator Author

Blocked by #664

@mpstefan mpstefan modified the milestones: v1.0.0, v1.0.1 Aug 11, 2023
@mpstefan
Copy link
Collaborator Author

mpstefan commented Aug 21, 2023

https://docs.nginx.com/nginx-ingress-controller/logging-and-monitoring/prometheus/

controller_nginx_reloads_total. Number of successful NGINX reloads. This includes the label reason with 2 possible values endpoints (the reason for the reload was an endpoints update) and other (the reload was caused by something other than an endpoint update like an ingress update).

controller_nginx_reload_errors_total. Number of unsuccessful NGINX reloads.

@mpstefan mpstefan modified the milestones: v1.0.1, v1.0.0 Aug 21, 2023
@mpstefan mpstefan added blocked Blocked by other issue refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Aug 21, 2023
@ciarams87 ciarams87 self-assigned this Sep 12, 2023
@ciarams87 ciarams87 removed the blocked Blocked by other issue label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Additions or changes to metrics from NKG refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants