Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPRoute partial validity #485

Closed
Tracked by #1173
kate-osborn opened this issue Mar 17, 2023 · 1 comment · Fixed by #1160
Closed
Tracked by #1173

HTTPRoute partial validity #485

kate-osborn opened this issue Mar 17, 2023 · 1 comment · Fixed by #1160
Assignees
@bjee19
Labels
area/httproute/core Relates to all Core features of HTTPRoute enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/extra-small Estimated to be completed within a day
Milestone
v1.0.0

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Mar 17, 2023 •
edited
Loading

As a user of NGF
I want to know when my HTTPRoute is partially invalid
So that I can fix the issue.

A/C:

  • Replace the TODO condition with the PartiallyInvalid condition on an HTTPRoute when one of the rules is invalid.
  • Resolve FIXME
@kate-osborn kate-osborn modified the milestones: v0.3.0, v0.4.0 Mar 21, 2023
@kate-osborn kate-osborn added the area/httproute/core Relates to all Core features of HTTPRoute label Mar 21, 2023
@kate-osborn kate-osborn added this to the v1.0.0 milestone Mar 21, 2023
@kate-osborn kate-osborn added enhancement New feature or request and removed proposal labels Mar 21, 2023
@kate-osborn kate-osborn added the sig-gateway Tracks work happening in sig-gateway label Mar 24, 2023
@mpstefan mpstefan mentioned this issue May 16, 2023
Closed
@mpstefan mpstefan added the tracking To track external issues or changes that will affect NKG label May 16, 2023
@pleshakov pleshakov removed their assignment Aug 2, 2023
@mpstefan mpstefan modified the milestones: v1.0.0, v1.0.1 Aug 11, 2023
@mpstefan mpstefan removed this from the v1.0.1 milestone Sep 11, 2023
@mpstefan mpstefan added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Sep 11, 2023
@pleshakov pleshakov added backlog Currently unprioritized work. May change with user feedback or as the product progresses. and removed backlog Currently unprioritized work. May change with user feedback or as the product progresses. sig-gateway Tracks work happening in sig-gateway tracking To track external issues or changes that will affect NKG labels Oct 9, 2023
@kate-osborn kate-osborn removed the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Oct 9, 2023
@kate-osborn kate-osborn added this to the v1.0.1 milestone Oct 9, 2023
@kate-osborn kate-osborn added refined Requirements are refined and the issue is ready to be implemented. size/extra-small Estimated to be completed within a day labels Oct 9, 2023
@ja20222 ja20222 modified the milestones: v1.0.1, v1.0.0 Oct 16, 2023
@bjee19 bjee19 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Oct 18, 2023
@bjee19 bjee19 self-assigned this Oct 18, 2023
@mpstefan mpstefan modified the milestones: v1.0.0, v1.1.0 Oct 18, 2023
@bjee19 bjee19 moved this from 🏗 In Progress to 🆕 New in NGINX Gateway Fabric Oct 18, 2023
@bjee19 bjee19 added blocked Blocked by other issue tracking To track external issues or changes that will affect NKG labels Oct 18, 2023
@bjee19
Copy link
Contributor

bjee19 commented Oct 18, 2023 •
edited
Loading

blocked until kubernetes-sigs/gateway-api#2429 is released in their 1.0 I was mistaken, this is not blocked as we are copying the condition to our code then once they release it, we will switch to their definition.

@bjee19 bjee19 removed their assignment Oct 18, 2023
@bjee19 bjee19 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Oct 18, 2023
@bjee19 bjee19 self-assigned this Oct 18, 2023
@bjee19 bjee19 removed blocked Blocked by other issue tracking To track external issues or changes that will affect NKG labels Oct 18, 2023
@bjee19 bjee19 modified the milestones: v1.1.0, v1.0.0 Oct 18, 2023
@bjee19 bjee19 mentioned this issue Oct 18, 2023
Merged
6 tasks
@bjee19 bjee19 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Oct 18, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Oct 19, 2023
@mpstefan mpstefan mentioned this issue Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjee19 bjee19

Labels
area/httproute/core Relates to all Core features of HTTPRoute enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/extra-small Estimated to be completed within a day
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Add PartiallyInvalid HTTPRoute Condition bjee19/nginx-gateway-fabric
5 participants
@pleshakov @mpstefan @kate-osborn @ja20222 @bjee19