Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Test for Upstream Settings #2736

Closed
Tracked by #2162
mpstefan opened this issue Oct 29, 2024 · 1 comment · Fixed by #2869
Closed
Tracked by #2162

Functional Test for Upstream Settings #2736

mpstefan opened this issue Oct 29, 2024 · 1 comment · Fixed by #2869
Assignees
@salonichf5
Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Milestone
v1.6.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Oct 29, 2024 •
edited
Loading

Issue to create a functional test surrounding the capabilities of the Upstream Settings Policy.

Acceptance

  • Test that when a UpstreamSettingsPolicy is created that the status of the UpstreamSettingsPolicy is Accepted
  • Ensure that the resultant NGINX configuration is what we expect based on the fields configured in the test UpstreamSettingsPolicy.
  • Test if the policy reference is a service not owned by NGF, no status is written to the policy
@mpstefan mpstefan mentioned this issue Oct 29, 2024
Open
@mpstefan mpstefan added enhancement New feature or request tests Pull requests that update tests and removed enhancement New feature or request labels Oct 29, 2024
@mpstefan mpstefan added this to the v1.5.0 milestone Oct 29, 2024
@sindhushiv sindhushiv modified the milestones: v1.5.0, v2.0.0 Nov 5, 2024
@sindhushiv sindhushiv mentioned this issue Nov 13, 2024
Closed
@mpstefan
Copy link
Collaborator Author

@kate-osborn to check the BackendTLSPolicy spec compared to this one.

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Nov 18, 2024
@salonichf5 salonichf5 self-assigned this Nov 27, 2024
@salonichf5 salonichf5 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Dec 2, 2024
@salonichf5 salonichf5 mentioned this issue Dec 5, 2024
Merged
6 tasks
@salonichf5 salonichf5 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Dec 6, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Dec 20, 2024
@salonichf5 salonichf5 reopened this Dec 20, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in NGINX Gateway Fabric Dec 20, 2024
@salonichf5 salonichf5 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Dec 20, 2024
@salonichf5 salonichf5 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Dec 20, 2024
@salonichf5 salonichf5 closed this as completed by moving to ✅ Done in NGINX Gateway Fabric Dec 20, 2024
@salonichf5 salonichf5 moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salonichf5 salonichf5

Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Functional tests for UpstreamSettings Policy salonichf5/nginx-gateway-fabric
3 participants
@mpstefan @sindhushiv @salonichf5