Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run functional and NGF tests using ginkgo #1677

Closed
pleshakov opened this issue Mar 13, 2024 · 2 comments · Fixed by #1833
Closed

Run functional and NGF tests using ginkgo #1677

pleshakov opened this issue Mar 13, 2024 · 2 comments · Fixed by #1833
Assignees
@lucacome
Labels
tech-debt Short-term pain, long-term benefit tests Pull requests that update tests

Comments

@pleshakov
Copy link
Contributor

Our functional and NFR tests use ginkgo https://github.com/nginxinc/nginx-gateway-fabric/tree/e1d7691b04bac1e73d02f42a019c4ba3354f52a4/tests

However, we run them using go test.

Run tests using ginkgo using its recommended configuration https://onsi.github.io/ginkgo/#recommended-continuous-integration-configuration
@pleshakov pleshakov mentioned this issue Mar 13, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Mar 28, 2024
@sjberman sjberman removed the stale Pull requests/issues with no activity label Apr 10, 2024
@mpstefan
Copy link
Collaborator

What's the impact of changing the command that we use to test?

@mpstefan mpstefan added tests Pull requests that update tests tech-debt Short-term pain, long-term benefit labels Apr 10, 2024
@mpstefan mpstefan moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Apr 17, 2024
@lucacome lucacome mentioned this issue Apr 19, 2024
Merged
6 tasks
@lucacome lucacome moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Apr 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucacome lucacome

Labels
tech-debt Short-term pain, long-term benefit tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run functional and NFR tests with ginkgo nginxinc/nginx-gateway-fabric
4 participants
@lucacome @pleshakov @mpstefan @sjberman