Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for reconciling resources #1463

Open
kate-osborn opened this issue Jan 12, 2024 · 0 comments
Open

Add system test for reconciling resources #1463

kate-osborn opened this issue Jan 12, 2024 · 0 comments
Labels
tests Pull requests that update tests
Milestone

Comments

@kate-osborn
Copy link
Contributor

Is your enhancement request related to a problem? Please describe.
We do not currently test the k8s controller's reconciling logic that filters out resource events. For example, resources that have a generation field should not be reconciled when that generation has not changed. See #1422 for more details on how this works.

What would you like to be added:
A functional test that ensures we don't reconcile resource events that do not contain any updates to the NGINX configuration.
This test would involve making changes to resources that aren't material to NGF (e.g. updating the labels of an HTTPRoute) and verifying the following:

  1. The controller did not reconcile the resource. This can be verified through the controller_runtime_reconcile_total prometheus metric.
  2. The nginx configuration was not updated. This can be verified by checking the nginx configuration version.

Why this is needed:
To cover untested functionality of NGF.

@kate-osborn kate-osborn added the enhancement New feature or request label Jan 12, 2024
@mpstefan mpstefan added the tests Pull requests that update tests label Jan 29, 2024
@mpstefan mpstefan changed the title Add functional test for reconciling resources Add system test for reconciling resources Jan 29, 2024
@mpstefan mpstefan removed the enhancement New feature or request label Jan 29, 2024
@mpstefan mpstefan added this to the v1.3.0 milestone Jan 29, 2024
@mpstefan mpstefan modified the milestones: v1.3.0, v2.0.0 Apr 23, 2024
@mpstefan mpstefan modified the milestones: v1.4.0, v2.0.0 Jun 4, 2024
@mpstefan mpstefan modified the milestones: v1.5.0, v2.0.0 Oct 7, 2024
@mpstefan mpstefan modified the milestones: v1.6.0, v2.1.0 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants