Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation support for Ubuntu 24.04 (Noble) #708

Closed
mnlm opened this issue May 5, 2024 · 2 comments · Fixed by #719
Closed

Validation support for Ubuntu 24.04 (Noble) #708

mnlm opened this issue May 5, 2024 · 2 comments · Fixed by #719
Labels
enhancement Enhance/improve an existing feature
Milestone

Comments

@mnlm
Copy link

mnlm commented May 5, 2024

Is your feature request related to a problem? Please describe

Playing around with the latest Ubuntu 24.04 (Noble) release I noticed the role's validation fails:

ASK [nginxinc.nginx : Check whether you are using a supported NGINX distribution] **********************************************************************************************************
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: {{ ansible_facts['distribution'] | lower in nginx_distributions.keys() |
list }}
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: {{ (ansible_facts['distribution_version'] | regex_search('\d{1,2}\.\d{2}')
| float in nginx_distributions[ansible_facts['distribution'] | lower]['versions'] | map('float')) if ansible_facts['distribution'] | lower in ['alpine', 'ubuntu'] else
ansible_facts['distribution_major_version'] in nginx_distributions[ansible_facts['distribution'] | lower]['versions'] | string }}
fatal: [***]: FAILED! => {
    "assertion": "{{ (ansible_facts['distribution_version'] | regex_search('\\d{1,2}\\.\\d{2}') | float in nginx_distributions[ansible_facts['distribution'] | lower]['versions'] | map('float')) if ansible_facts['distribution'] | lower in ['alpine', 'ubuntu'] else ansible_facts['distribution_major_version'] in nginx_distributions[ansible_facts['distribution'] | lower]['versions'] | string }}",
    "changed": false,
    "evaluated_to": false,
    "msg": "Your distribution, Ubuntu 24.04 (x86_64), is not supported by NGINX Open Source."
}
...ignoring

The role ran with default vars except for:

nginx_setup_license: false
nginx_install_epel_release: false

Other than this validation error the role works on Noble. So does NGINX:

***:~$ nginx -v
nginx version: nginx/1.25.5
***:~$ systemctl status nginx
● nginx.service - nginx - high performance web server
     Loaded: loaded (/usr/lib/systemd/system/nginx.service; enabled; preset: enabled)
     Active: active (running) since Sun 2024-05-05 15:20:13 UTC; 3min 40s ago

Describe the solution you'd like

Update validation to include the latest Ubuntu 24.04 release.

@alessfg alessfg added the enhancement Enhance/improve an existing feature label May 6, 2024
@alessfg alessfg added this to the 0.24.3 milestone May 6, 2024
@shivamb
Copy link

shivamb commented May 24, 2024

Getting same issue

@alessfg
Copy link
Collaborator

alessfg commented May 24, 2024

I need to update the CI pipeline and add Ubuntu noble to the list of supported platforms. I'll hopefully get to it early next week!

@alessfg alessfg linked a pull request May 29, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance/improve an existing feature
Development

Successfully merging a pull request may close this issue.

3 participants