Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emits deprecation warnings when building with Ruby 3.4 #1525

Open
jirutka opened this issue Dec 30, 2024 · 1 comment · May be fixed by #1544
Open

Emits deprecation warnings when building with Ruby 3.4 #1525

jirutka opened this issue Dec 30, 2024 · 1 comment · May be fixed by #1544

Comments

@jirutka
Copy link

jirutka commented Dec 30, 2024 •
edited
Loading 

src/ruby/nxt_ruby_stream_io.c: In function 'nxt_ruby_stream_io_new':
src/ruby/nxt_ruby_stream_io.c:76:5: error: 'rb_data_object_wrap_warning' is deprecated: by TypedData [-Werror=deprecated-declarations]
   76 |     self = Data_Wrap_Struct(class, 0, 0, (void *) (uintptr_t) arg);
      |     ^~~~
In file included from /usr/include/ruby-3.4.0/ruby/internal/core.h:27,
                 from /usr/include/ruby-3.4.0/ruby/ruby.h:29,
                 from /usr/include/ruby-3.4.0/ruby.h:38,
                 from src/ruby/nxt_ruby.h:11,
                 from src/ruby/nxt_ruby_stream_io.c:7:
/usr/include/ruby-3.4.0/ruby/internal/core/rdata.h:293:1: note: declared here
  293 | rb_data_object_wrap_warning(VALUE klass, void *ptr, RUBY_DATA_FUNC mark, RUBY_DATA_FUNC free)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/ruby/nxt_ruby_stream_io.c: In function 'nxt_ruby_stream_io_gets':
src/ruby/nxt_ruby_stream_io.c:99:5: error: 'rb_data_object_get_warning' is deprecated: by TypedData [-Werror=deprecated-declarations]
   99 |     Data_Get_Struct(obj, nxt_ruby_ctx_t, rctx);
      |     ^~~~~~~~~~~~~~~
/usr/include/ruby-3.4.0/ruby/internal/core/rdata.h:325:1: note: declared here
  325 | rb_data_object_get_warning(VALUE obj)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
src/ruby/nxt_ruby_stream_io.c: In function 'nxt_ruby_stream_io_read':
src/ruby/nxt_ruby_stream_io.c:155:5: error: 'rb_data_object_get_warning' is deprecated: by TypedData [-Werror=deprecated-declarations]
  155 |     Data_Get_Struct(obj, nxt_ruby_ctx_t, rctx);
      |     ^~~~~~~~~~~~~~~
/usr/include/ruby-3.4.0/ruby/internal/core/rdata.h:325:1: note: declared here
  325 | rb_data_object_get_warning(VALUE obj)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
src/ruby/nxt_ruby_stream_io.c: In function 'nxt_ruby_stream_io_puts':
src/ruby/nxt_ruby_stream_io.c:211:5: error: 'rb_data_object_get_warning' is deprecated: by TypedData [-Werror=deprecated-declarations]
  211 |     Data_Get_Struct(obj, nxt_ruby_ctx_t, rctx);
      |     ^~~~~~~~~~~~~~~
/usr/include/ruby-3.4.0/ruby/internal/core/rdata.h:325:1: note: declared here
  325 | rb_data_object_get_warning(VALUE obj)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
src/ruby/nxt_ruby_stream_io.c: In function 'nxt_ruby_stream_io_write':
src/ruby/nxt_ruby_stream_io.c:229:5: error: 'rb_data_object_get_warning' is deprecated: by TypedData [-Werror=deprecated-declarations]
  229 |     Data_Get_Struct(obj, nxt_ruby_ctx_t, rctx);
      |     ^~~~~~~~~~~~~~~
/usr/include/ruby-3.4.0/ruby/internal/core/rdata.h:325:1: note: declared here
  325 | rb_data_object_get_warning(VALUE obj)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [build/Makefile:2571: build/src/ruby/nxt_ruby_stream_io-ruby.o] Error 1

See https://bugs.ruby-lang.org/issues/19998
@jirutka jirutka changed the title Fails to build with Ruby 3.4 Emits deprecation warnings when building with Ruby 3.4 Dec 30, 2024
@ac000
Copy link
Member

ac000 commented Jan 13, 2025

Until this is addressed you should be able to build with make E=0

E=0 will stop warnings from being treated as errors.

ac000 added a commit to ac000/unit that referenced this issue Jan 21, 2025
@ac000
ruby: Fix build failures with Ruby 3.4
60fc255 
Ruby 3.4 started to actually mark some deprecated functions as
*deprecated* now resulting in compiler warnings (which due to -Werror we
treat as errors and thus the build fails).

The *new* functions were actually introduced back in Ruby 1.9.2, so have
been around for quite some time. We claim support for Ruby 2.0 onwards
so this is more than fine.

The new API replaces the old 'mark' and 'free' parameters with a struct
that allows for more fine tuning/configuration. We never made use of
either of those parameters and so the only member of this struct we
*need* to set is the structure wrapper name.

Ruby pytests still pass after this change...

Closes: nginx#1525
Link: <https://bugs.ruby-lang.org/issues/19998>
Signed-off-by: Andrew Clayton <[email protected]>
@ac000 ac000 linked a pull request Jan 21, 2025 that will close this issue
ruby: Fix build failures with Ruby 3.4 #1544
Open
ac000 added a commit to ac000/unit that referenced this issue Jan 22, 2025
@ac000
ruby: Fix build failures with Ruby 3.4
7b7b29f 
Ruby 3.4 started to actually mark some deprecated functions as
*deprecated* now resulting in compiler warnings (which due to -Werror we
treat as errors and thus the build fails).

The *new* functions were actually introduced back in Ruby 1.9.2, so have
been around for quite some time. We claim support for Ruby 2.0 onwards
so this is more than fine.

The new API replaces the old 'mark' and 'free' parameters with a struct
that allows for more fine tuning/configuration. We never made use of
either of those parameters and so the only members of this struct we
*need* to set is the structure wrapper name and the dsize function
pointer which is passed a pointer to the underlying wrapped structure to
calculate its memory usage. While this is *not* required the
documentation *recommends* setting it (though it doesn't say how it's
used).

Ruby pytests still pass after this change...

Closes: nginx#1525
Link: <https://bugs.ruby-lang.org/issues/19998>
Link: <https://docs.ruby-lang.org/en/3.4/extension_rdoc.html#label-C+struct+to+Ruby+object>
Signed-off-by: Andrew Clayton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ruby: Fix build failures with Ruby 3.4 ac000/unit
2 participants
@ac000 @jirutka