Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Accepted condition and bump observed gen for all GatewayClasses with our controller name #775

Closed
kate-osborn opened this issue Jun 21, 2023 · 0 comments · Fixed by #804
Closed

Set Accepted condition and bump observed gen for all GatewayClasses with our controller name #775

kate-osborn opened this issue Jun 21, 2023 · 0 comments · Fixed by #804
Assignees
@sjberman
Labels
area/gatewayclass/core Relates to all Core features of GatewayClass bug Something isn't working refined Requirements are refined and the issue is ready to be implemented.
Milestone
v0.5.0

Comments

@kate-osborn
Copy link
Contributor

The GatewayClassObservedGenerationBump conformance test expects any GatewayClass with the NKG controller name to have the Accepted condition set and the observed generation bumped on update.

Acceptance Criteria:

  • All GatewayClasses that have our controller name, must have the Accepted condition on it. Can be false if the GatewayClass name does not match the one provided via cli arg.
  • All GatewayClasses that have our controller name, must have the observed generation of all its Status. Conditions bumped after a spec update.
  • Make sure the GatewayClassObservedGenerationBump passes.
@ja20222 ja20222 added this to the v0.5.0 milestone Jun 22, 2023
@ja20222 ja20222 added bug Something isn't working area/gateway/core Relates to all Core features of Gateway area/gatewayclass/core Relates to all Core features of GatewayClass and removed area/gateway/core Relates to all Core features of Gateway labels Jun 22, 2023
@mpstefan mpstefan mentioned this issue Jun 27, 2023
Closed
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Jun 28, 2023
@sjberman sjberman self-assigned this Jun 28, 2023
@sjberman sjberman mentioned this issue Jun 29, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
area/gatewayclass/core Relates to all Core features of GatewayClass bug Something isn't working refined Requirements are refined and the issue is ready to be implemented.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Set GatewayClass status for ignored GatewayClasses sjberman/nginx-gateway-fabric
4 participants
@mpstefan @sjberman @kate-osborn @ja20222