Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ResolvedRef Condition to True in HTTPRoute status when all references are resolved #611

Closed
pleshakov opened this issue May 3, 2023 · 1 comment · Fixed by #645
Closed

Set ResolvedRef Condition to True in HTTPRoute status when all references are resolved #611

pleshakov opened this issue May 3, 2023 · 1 comment · Fixed by #645
Assignees
@kate-osborn
Labels
area/httproute/core Relates to all Core features of HTTPRoute conformance Relates to passing Gateway API conformance tests enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Milestone
v0.4.0

Comments

@pleshakov
Copy link
Contributor

Gateway API prescribes setting ResolvedRef condition
https://github.com/kubernetes-sigs/gateway-api/blob/c67f3fd31976ea74ea06a78c2a88ae38df95a41d/apis/v1beta1/shared_types.go#L255-L290

NKG already implements it -- https://github.com/nginxinc/nginx-kubernetes-gateway/blob/f74c06ded5c3d647b0909fe542f3e70dbc96774c/internal/state/conditions/conditions.go#L253-L295 -- however, only when references are not resolved.

Implement the happy path case when references are resolved.

Also, conformance tests require it. Example: https://github.com/kubernetes-sigs/gateway-api/blob/6efcfdf8aff7aa7c3ed8deb956e5b93eed779234/conformance/tests/httproute-matching.go#L46

Acceptance criteria:
@ja20222 ja20222 added area/httproute/core Relates to all Core features of HTTPRoute enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. and removed proposal labels May 4, 2023
@ja20222 ja20222 added this to the v0.4.0 milestone May 4, 2023
@pleshakov pleshakov added the conformance Relates to passing Gateway API conformance tests label May 10, 2023
This was referenced May 10, 2023
Closed
Closed
@mpstefan
Copy link
Collaborator

Additional A/C: Include InvalidListener, UnsupportedValue, and any other undocumented reasons in condition status.

@kate-osborn kate-osborn self-assigned this May 16, 2023
@kate-osborn kate-osborn mentioned this issue May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kate-osborn kate-osborn

Labels
area/httproute/core Relates to all Core features of HTTPRoute conformance Relates to passing Gateway API conformance tests enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Set ResolvedRefs condition to true on HTTPRoutes nginx/nginx-gateway-fabric
4 participants
@pleshakov @mpstefan @kate-osborn @ja20222