Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow duplicate TargetRefs for NGF Policies #2923

Open
kate-osborn opened this issue Dec 17, 2024 · 2 comments · May be fixed by #2986
Open

Don't allow duplicate TargetRefs for NGF Policies #2923

kate-osborn opened this issue Dec 17, 2024 · 2 comments · May be fixed by #2986
Assignees
@bjee19
Labels
enhancement New feature or request

Comments

@kate-osborn
Copy link
Contributor

It's possible to create an ObservabilityPolicy or UpstreamSettingsPolicy with duplicate targetRefs. This is not a valid configuration and should be prevented.

A/C:

  • Add CEL validation to ObservabilityPolicy and UpstreamSettingsPolicy to ensure that targetRefs are unique.

Dev Notes:
@kate-osborn kate-osborn added the enhancement New feature or request label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Jan 1, 2025
@mpstefan
Copy link
Collaborator

mpstefan commented Jan 2, 2025

Hey @kate-osborn

What happens when the user does put in a duplicate target ref? Any idea on the effort for a fix?

@mpstefan mpstefan removed the stale Pull requests/issues with no activity label Jan 2, 2025
@bjee19 bjee19 self-assigned this Jan 6, 2025
@bjee19 bjee19 linked a pull request Jan 7, 2025 that will close this issue
Open
6 tasks
@lucacome lucacome moved this from 🆕 New to 👀 In Review in NGINX Gateway Fabric Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjee19 bjee19

Labels
enhancement New feature or request
Projects
NGINX Gateway Fabric
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add validation to ensure no duplicate TargetRefs in policies bjee19/nginx-gateway-fabric
3 participants
@mpstefan @kate-osborn @bjee19