Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGINX Plus: Server Zone Metrics are not Emitted #2220

Closed
mpstefan opened this issue Jul 10, 2024 · 1 comment · Fixed by #2360
Closed

NGINX Plus: Server Zone Metrics are not Emitted #2220

mpstefan opened this issue Jul 10, 2024 · 1 comment · Fixed by #2360
Assignees
@sjberman
Labels
area/observability Relates to all observability features and bugs enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone
v1.4.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Jul 10, 2024 •
edited
Loading

NGF currently does not emit any server_zone metrics from NGINX Plus. This appears to be an oversight in our exposure of metrics, so this is something we need to fix.

Reported by Dan Edgar:

Image

Acceptance

  • All server_zone metrics emitted by NGINX Plus when used as our data plane should be exposed on our metrics endpoint.
  • An NGINX directive is added to every location in every server block that NGF generates so that a server_zone metric is emitted for each location.
@mpstefan mpstefan added bug Something isn't working area/nginx-configuration Relates to nginx configuration area/observability Relates to all observability features and bugs and removed area/nginx-configuration Relates to nginx configuration labels Jul 10, 2024
@mpstefan mpstefan added this to the v1.4.0 milestone Jul 10, 2024
@mpstefan mpstefan added enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days and removed bug Something isn't working labels Jul 15, 2024
@lucacome
Copy link
Member

https://nginx.org/en/docs/http/ngx_http_api_module.html#status_zone

@sjberman sjberman self-assigned this Aug 6, 2024
@sjberman sjberman mentioned this issue Aug 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
area/observability Relates to all observability features and bugs enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Add server zone metrics sjberman/nginx-gateway-fabric
3 participants
@lucacome @mpstefan @sjberman