Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show code coverage for NGF PRs and Project #1514

Closed
mpstefan opened this issue Jan 29, 2024 · 2 comments · Fixed by #1626
Closed

Show code coverage for NGF PRs and Project #1514

mpstefan opened this issue Jan 29, 2024 · 2 comments · Fixed by #1626
Assignees
@lucacome
Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/extra-small Estimated to be completed within a day
Milestone
v1.2.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Jan 29, 2024 •
edited
Loading

As a contributor of NGF
I want code coverage to be displayed as a badge on the repository and in every PR
So that I understand how my contribution affects code coverage and where the baseline is for the project.

Acceptance

  • A badge which displays NGF code coverage is added to the README.
  • The change in code coverage is added as a comment to every PR.
@mpstefan mpstefan added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Jan 29, 2024
@mpstefan
Copy link
Collaborator Author

Discussed making this a bot comment on PRs for how much code coverage changed under certain circumstances.

@lucacome
Copy link
Member

lucacome commented Feb 2, 2024

we can use https://about.codecov.io

@mpstefan mpstefan added release-engineering Relates to all release engineering tasks and removed backlog Currently unprioritized work. May change with user feedback or as the product progresses. labels Feb 26, 2024
@mpstefan mpstefan added this to the v1.2.0 milestone Feb 26, 2024
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/extra-small Estimated to be completed within a day labels Feb 26, 2024
@mpstefan mpstefan changed the title Show code coverage for NGF as a badge in readme Show code coverage for NGF PRs and Project Feb 26, 2024
@lucacome lucacome self-assigned this Feb 26, 2024
@lucacome lucacome mentioned this issue Feb 28, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucacome lucacome

Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/extra-small Estimated to be completed within a day
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Add Codecov lucacome/nginx-kubernetes-gateway
2 participants
@lucacome @mpstefan