Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling SASS partials #1

Open
mattarau opened this issue Jul 7, 2014 · 1 comment
Open

Handling SASS partials #1

mattarau opened this issue Jul 7, 2014 · 1 comment

Comments

@mattarau
Copy link

mattarau commented Jul 7, 2014

Hey @joshdmiller,

I've found your warlock project while looking for solutions of some issues with SASS partials on an AngularJS modular project and was taking I look at this spell to see if it maybe could be a future solution.

The thing is that, if the idea is to use "convention over configuration", it might be better to exclude any .sass or .scss files that starts with an underscore, since they are SASS partials and conventionally should be imported and not directly compiled.

It seems that this is only necessary because of a bug on the SASS compiler that doesn't ignore partials files as reported on this grunt-contrib-sass issue.

@joshdmiller
Copy link
Member

@mdentinho - You're absolutely right and I'd happily take a pull request. :-)

PS: Super sorry this took so long to reply. With multiple repositories with varying activity levels, it can be very difficult to keep up if I don't see the initial email. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants