feat(dropdown): auto and array support in placement #1814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/dropdown/dropdown.spec.ts
Outdated
| const dropDownEle = getDropdownEl(compiled); | ||
|
|
||
| expect(dropDownEle).toHaveCssClass('dropdown'); | ||
| expect(dropDownEle.getAttribute('ng-reflect-placement')).toEqual('auto'); |
There was a problem hiding this comment.
We should not use ng-reflect- attributes in tests as it is impl-specific and can change at any moment (not to mention the fact that it is not there in production mode).
TBH I'm not sure what you are trying to assert with this test so it is hard for me to suggest changes...
src/dropdown/dropdown.spec.ts
Outdated
| const dropDownEle = getDropdownEl(compiled); | ||
|
|
||
| expect(dropDownEle).toHaveCssClass('dropdown'); | ||
| expect(dropDownEle.getAttribute('ng-reflect-placement')).toEqual('left-top,top-left,auto'); |
There was a problem hiding this comment.
Same comment as above...
|
|
||
| /** | ||
| */ | ||
| @Directive( | ||
| {selector: '[ngbDropdownMenu]', host: {'[class.dropdown-menu]': 'true', '[class.show]': 'dropdown.isOpen()'}}) | ||
| export class NgbDropdownMenu { | ||
| placement: Placement = 'bottom'; |
There was a problem hiding this comment.
Why not PlacementArray?
There was a problem hiding this comment.
Oh, I see, sorry for the noise.
src/dropdown/dropdown.ts
Outdated
| @@ -102,9 +108,17 @@ export class NgbDropdown { | |||
| this._zoneSubscription = ngZone.onStable.subscribe(() => { this._positionMenu(); }); | |||
| } | |||
|
|
|||
| isUp() { return this.placement.indexOf('top') !== -1; } | |||
| isUp() { | |||
There was a problem hiding this comment.
Maybe we should simplify those methods in the following way:
isDown()is true only when there isbottomsomewhere in placementisUp()=!isDown()
WDYT?
In any case we should tests for this logic.
mschoudry
force-pushed
the
feat_auto_placement_dropdown
branch
from
7ebcbbd to
7be431b
Compare
rmeans
pushed a commit
to fcsa-teamhammer/ng-bootstrap
that referenced
this pull request
Oct 18, 2017
|
Is there a fix for this? |
|
Is there any fix for this ??? |
|
A fix would be awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for auto placement and array can be defined inside placement attribute of dropdown.