Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty directories are not zipped #28

Open
s-pic opened this issue Dec 6, 2018 · 4 comments
Open

Empty directories are not zipped #28

s-pic opened this issue Dec 6, 2018 · 4 comments

Comments

@s-pic
Copy link

s-pic commented Dec 6, 2018

I figured out that if I do not put a file in a directory, it will not go into the archive.
Is there some sort of option I can use?

Here is what I am doing:
cd build && bestzip ../myproject-build.zip * .env.example

/build contains files, subfolders with files and also empty subfolders.

I am on a windows machine.

@nfriedly
Copy link
Owner

nfriedly commented Dec 6, 2018

Hi @GeoMC,

Can you try running the command with --force=node and --force=native and let me know what the results are for each variation?

@nfriedly
Copy link
Owner

nfriedly commented Dec 7, 2018

Actually, nevermind. I made a test case that reproduces the bug, so now I just need to figure out how to fix it.

@Kovvah
Copy link

Kovvah commented Apr 14, 2021

...2 years later ahah

No fix planned ? This issue is blocking me in my delivery process :(

@nfriedly
Copy link
Owner

Sorry, this was from right before my daughter was born, and everything got more or less forgotten after that.

If you can come up with a fix (and hopefully a test, since I'm not sure what happened to the one I made), I can get it merged in and shipped pretty soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants