Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked folders not followed #10

Closed
Lampei opened this issue Jan 17, 2018 · 8 comments · Fixed by #36
Closed

Linked folders not followed #10

Lampei opened this issue Jan 17, 2018 · 8 comments · Fixed by #36

Comments

@Lampei
Copy link
Collaborator

Lampei commented Jan 17, 2018

On Windows, when subfolders are "symlink" folders rather than the actual folders, bestzip does not follow them to get their contents.

@Lampei
Copy link
Collaborator Author

Lampei commented Jan 17, 2018

It looks like the latest version of archiver supports symlinks. Is there a reason for bestzip only using v0.21 ? Looks like they're up to 2.0.0 now.

@peacechen
Copy link
Collaborator

Probably because no one's updated it :)

If you don't mind updating, testing and creating a PR, we'll merge and release the new version.

@Lampei
Copy link
Collaborator Author

Lampei commented Jan 17, 2018

Once my sprint's finished (today), I'll try upgrading and see what happens...

@Lampei
Copy link
Collaborator Author

Lampei commented Jan 17, 2018

I've reviewed the code and bulk was removed starting with 2.0.0 in archiver, so the code will need some updating in order to work correctly (and testing). I tried just updating to v1.3.0, but that still did not fix the issue with links.

@Lampei
Copy link
Collaborator Author

Lampei commented Jan 19, 2018

I created a pull request for this issue. Only change was to "matches" from ** to **/**. If we updated the archiver to latest, there would be many things to test and a completely different way of handling the directory zipping.

@peacechen
Copy link
Collaborator

Thanks @Lampei . I just remembered that you have merge permissions too :)

As long as it continues to work on Windows as well as Linux, I vote to merge it.

@Lampei
Copy link
Collaborator Author

Lampei commented Jan 19, 2018

It has definitely been working for me in Windows, but I don't have a *nix machine to test that side of things with.

@nfriedly
Copy link
Owner

This is now fixed in v2.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants